Problem/Motivation

\Drupal\Core\Field\Plugin\Field\FieldFormatter\EntityReferenceFormatterBase::prepareView() triggers deprecations on PHP 8.5

Steps to reproduce

Run \Drupal\Tests\field\Kernel\EntityReference\EntityReferenceFormatterTest

Proposed resolution

Don't

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557384

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

alexpott created an issue. See original summary.

alexpott’s picture

Status: Active » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Locally on 8.5.0RC3

Running EntityReferenceFormatterTest gave me 3 tests triggered 1 PHP deprecation:
Applying the MR I got 0

Way to make me feel like a noob didn't know you can pass multiple variables to check :(

LGTM!

catch’s picture

Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed d5420b3a on 11.3.x
    fix: #3557384 \Drupal\Core\Field\Plugin\Field\FieldFormatter\...

  • catch committed d6013738 on 11.x
    fix: #3557384 \Drupal\Core\Field\Plugin\Field\FieldFormatter\...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.