Problem/Motivation

The derivate system tries to use NULL as a special array key - but that does not work - NULL is converted to an empty string and in PHP 8.5 this triggers a deprecation.

Steps to reproduce

Run \Drupal\KernelTests\Core\Plugin\InspectionTest

Proposed resolution

Don't use NULL as a derivative ID - use an empty string.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557357

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !13786

ankitv18’s picture

ankitv18 commented
Status: Needs review » Reviewed & tested by the community

Looks good, legit fix as per https://github.com/phpstan/phpstan/issues/13592
Moving into RTBC

  • catch committed cd0b9b30 on 11.3.x 
    fix: #3557357 \Drupal\Component\Plugin\Discovery\...

  • catch committed 18702fdb on 11.x 
    fix: #3557357 \Drupal\Component\Plugin\Discovery\...

catch closed merge request !13786

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.