Problem/Motivation

\Drupal\Core\Plugin\DefaultSingleLazyPluginCollection::addInstanceId() causes deprecations on PHP 8.5 when $id is NULL.

Steps to reproduce

Run Drupal\Tests\block\Kernel\BlockStorageUnitTest

Proposed resolution

Trigger the exception in BlockPluginCollection earlier

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557346

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !13784

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Reviewed & tested by the community

Looks like this approach is cleaner

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 2584738b on 11.3.x 
    fix: #3557346 \Drupal\Core\Plugin\DefaultSingleLazyPluginCollection::...

  • catch committed 7f196889 on 11.x 
    fix: #3557346 \Drupal\Core\Plugin\DefaultSingleLazyPluginCollection::...

catch closed merge request !13784

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.