Problem/Motivation

Commit #70d3741 added support for config translations. Unfortunately this breaks an existing installation of the config_translation module is not also enabled.

Steps to reproduce

Configure the module with 2.1.0-rc5 without installing config_translation.
Update to 2.1.0-rc6.

Proposed resolution

List config_translation as a dependency, or properly adjust the code to not make it required.

Remaining tasks

Either make config_translation required, or rework the current code to not require it.

User interface changes

n/a

API changes

n/a

Data model changes

n/a

Issue fork entity_extra_field-3557250

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

damienmckenna created an issue. See original summary.

pasqualle made their first commit to this issue’s fork.

pasqualle opened merge request !36

pasqualle’s picture

pasqualle
Location 🇭🇺 Budapest
commented

Made a dirty quickfix to remove the error.

grgcrlsn321 made their first commit to this issue’s fork.

grgcrlsn321’s picture

grgcrlsn321 commented

I went ahead and rewrote the code and removed it. This is working good on my end and solves the issue for config_translation being a dependency.

grgcrlsn321’s picture

grgcrlsn321 commented
Status: Active » Needs review

Setting to needs review.

smustgrave’s picture

smustgrave commented
Priority: Normal » Major

Got hit with this today when attempting to upgrade and it was causing the site to crash.

ericgsmith’s picture

ericgsmith commented
Status: Needs review » Needs work

MR36 is a good work around for people impacted by this (the other work around being to enable content translation).

I'm setting this to needs work though as I think the issue summary still stands that the module should either list config_translation as a dependency, or properly adjust the code to not make it required. By properly adjust the code - I think that means check appropriately that it is only adding dependencies to config translation when the module is enabled. MR36 current reverts the feature entirely.

My preference is that config translation remains optional - I'm not sure if there is some prior art from other modules we can take inspiration from here? Seems like initial changes from @pasqualle were heading in that direction.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks, always feel free to ping us, if something like this happens! We're on it.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented
Version: 2.1.0-rc6 » 2.1.x-dev
Assigned: Unassigned » grevil

grevil closed merge request !36

grevil opened merge request !38

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review

Alright, that's it! Works without config translation again!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

I'll merge this and tag a new release, as soon as it's RTBC'd. Thanks @grevil!

ericgsmith’s picture

ericgsmith commented
Status: Needs review » Reviewed & tested by the community

Thanks team!

I've tested on 11.x - confirmed that when config_translate is not enabled with MR38 there are no issues or errors enabling / using the module. After enabling config_translate the translations specific routes / UI are present and appear to be functioning as expected - so it looks like no regression here for people with config translate enabled.

Code changes look good - phpstan is complaining "Ternary operator condition is always true." but clearly that is not the case - can ignore that one.

Setting as RTBC

  • grevil committed 05df8746 on 2.1.x 
    feat: #3557250 Requires config_translation even though it's not a...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Merged and tagged a new version: https://www.drupal.org/project/entity_extra_field/releases/2.1.0.

Thanks all!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.