Problem/Motivation

Followup for #2972622: Split the workspaces UI into a separate module and needed for #3486378: [Plan] Allow for / implement simplified content workflow with workspaces, we need to move all UI-related code to the workspaces_ui module.

Proposed resolution

Do it :)

Remaining tasks

Review.

User interface changes

Nope.

Introduced terminology

Nope.

API changes

A few form classes and entity handlers are moved.

Data model changes

Nope.

Release notes snippet

TBD.

Issue fork drupal-3557211

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

amateescu created an issue. See original summary.

amateescu opened merge request !13767

amateescu’s picture

amateescu commented
Status: Active » Needs review
catch’s picture

catch
he/him
Primary language English
commented

Is #3487005: Move the remaining UI code to the workspaces_ui module duplicate?

amateescu’s picture

amateescu commented

Yup.. just closed it.

dcam’s picture

dcam commented
Status: Needs review » Needs work

These changes are looking good. I read through them all and verified all the file, route, and library moves. Then I double-checked them in the browser. All the routes and libraries loaded properly.

This needs a manual rebase due to changes in the PHPStan baseline.

sourav_paul made their first commit to this issue’s fork.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented
Status: Needs work » Needs review
sourav_paul’s picture

sourav_paul
Location Kolkata
commented

I've rebased & regenerated phpstan-baseline, still PHPUnit Functional javascript test has failed.
It would be helpful, if anyone could look into this.

Thanks.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Per my earlier review in #6 I think everything is working properly. The rebase commit looks good. I'm willing to RTBC this.

PHPUnit Functional javascript test has failed.

These were random failures. I reran those tests and they passed afterward. Thank you for rebasing this, @sourav_paul.

sourav_paul’s picture

sourav_paul
Location Kolkata
commented

Thank you @decam for clarifying my doubt.

  • catch committed 2abd1f9e on 11.x 
    task: #3557211 Move the remaining UI bits to the workspaces_ui module...

  • catch committed a2dbcab0 on main 
    task: #3557211 Move the remaining UI bits to the workspaces_ui module...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Quite a lot moving around here, but there is not really any API surface to speak of. Committed/pushed to main and cherry-picked to 11.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13767

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.