Problem/Motivation

\Drupal\Core\ImageToolkit\ImageToolkitManager::getDefaultToolkitId requires system.image config exists but many kernel tests don't have it installed. If they do not you get deprecations on PHP 8.5.

Steps to reproduce

Run \Drupal\Tests\image\Kernel\ImageEffectsTest

Proposed resolution

Install the system module's config.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557167

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13764

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Kernel test failures seem related to the change, example Drupal\Tests\image\Kernel\ImageEffects "system module is not installed."

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review

Fixed that but forgot to push :)

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Still seems to have 1 kernel failure

Stable9Library Override (Drupal\KernelTests\Core\Theme\Stable9LibraryOverride)
✘ Stable 9 library overrides
┐
├ Drupal\Core\Extension\Exception\UnknownExtensionException: The theme stark does not exist or is not installed.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs work » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

All good now!

  • catch committed f9408cef on 11.3.x 
    fix: #3557167 Fix deprecations in \Drupal\Core\ImageToolkit\...

  • catch committed 3869ed8a on 11.x 
    fix: #3557167 Fix deprecations in \Drupal\Core\ImageToolkit\...

catch closed merge request !13764

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

andypost’s picture

andypost
he/him
Primary language Russian
commented

filed follow-up for new code #3559286: Fix EntityLinksTest for PHP 8.5

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.