Problem/Motivation

\Drupal\views\FieldViewsDataProvider::defaultFieldImplementation() tries to create a join when $data_table is NULL if $translation_join_type is language

Steps to reproduce

Run \Drupal\Tests\options\Kernel\Views\ViewsDataTest and Drupal\Tests\views\Kernel\Handler\FieldFieldTest

Proposed resolution

Don't

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3557142

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Issue summary: View changes

alexpott opened merge request !13759

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Issue tags: +PHP 8.5
Parent issue: » #3546535: [meta] Deal with NULL as array key/offset
smustgrave’s picture

smustgrave commented 
   1 test triggered 2 PHP deprecations:
    
    1) /builds/issue/drupal-3557142/core/lib/Drupal/Core/Config/Schema/Mapping.php:185
    Using null as an array offset is deprecated, use an empty string instead
    
    Triggered by:
    
    * Drupal\Tests\views\Kernel\ViewsDataTest::testViewsViewsDataIsBackendOverridable (18 times)
      /builds/issue/drupal-3557142/core/modules/views/tests/src/Kernel/ViewsDataTest.php:20
    
    2) /builds/issue/drupal-3557142/core/modules/views/tests/modules/views_test_config/src/Hook/ViewsTestConfigHooks.php:24
    Using null as an array offset is deprecated, use an empty string instead
    
    Triggered by:
    
    * Drupal\Tests\views\Kernel\ViewsDataTest::testViewsViewsDataIsBackendOverridable (10 times)
      /builds/issue/drupal-3557142/core/modules/views/tests/src/Kernel/ViewsDataTest.php:20
    
    OK, but there were issues!
    Tests: 1, Assertions: 1, Deprecations: 2.

Getting this from the gitlab runner.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@smustgrave yes but neither of them are the deprecation that is being fixed here. We're dealing with the deprecation trigger in \Drupal\views\FieldViewsDataProvider::defaultFieldImplementation

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

okay if we don't care about those ones here I'll mark.

  • catch committed e277b7c8 on 11.3.x 
    fix: #3557142 \Drupal\views\FieldViewsDataProvider::...

  • catch committed 73c48e9c on 11.x 
    fix: #3557142 \Drupal\views\FieldViewsDataProvider::...

catch closed merge request !13759

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented

An edge case was not handled. Opened #3582171: [PHP 8.5] Strengthen views data with entity types w/o data tables