Problem/Motivation

First off, thanks for creating this module! I might have done something wrong, but when I installed the plotly library via composer according to the instructions in the README/on the project page, plotly.min.js ended up at web/libraries/plotly.js/plotly.min.js. But this didn't load the library, I believe because charts_plotly.libraries.yml has it at web/libraries/plotly.js/dist/plotly.min.js.

Steps to reproduce

Install library via composer according to instructions in README, and disable using the CDN.

Proposed resolution

My workaround was to change the installer-paths key in composer.json to:

"web/libraries/plotly.js/dist": ["npm-asset/plotly.js-dist-min"],

That would be just a documentation change, but unsure if it would be better to change charts_plotly.libraries.yml instead.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork charts_plotly-3557000

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

mwymore created an issue. See original summary.

andileco made their first commit to this issue’s fork.

andileco opened merge request !6

andileco’s picture

andileco commented
Status: Active » Needs review

Thanks for that catch, @mwymore. The package.json option was generating the dist directory and the Composer option was not. And it gets a little masked by the CDN option. Please review this MR and let me know what you think.

mwymore’s picture

mwymore
he/him
Primary language English
Location Iowa
commented

I think it makes sense!

andileco’s picture

andileco commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.