Problem/Motivation

The module should definitely have CI and tests to ensure it works as expected!

  1. CI
  2. Basic Installation Tests
  3. Tests against the key functionalities

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork jsonapi_role_access-3556911

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » lrwebks

lrwebks made their first commit to this issue’s fork.

lrwebks opened merge request !3

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thanks, please also fix cspell and eslint if easy. Tests currently fail.

lrwebks’s picture

lrwebks commented
Status: Active » Needs work

I have added a basic functionality test now, unfortunately the JSON:API pages always result in a 404 and I haven't quite figured out why yet.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

VERY nice @lrwebks!

Did you see this? https://www.drupal.org/docs/core-modules-and-themes/core-modules/jsonapi...

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Maybe the module or other dependencies are not enabled? Or for any other reason the module doesn't offer that route?

lrwebks’s picture

lrwebks commented
Assigned: lrwebks » Unassigned

Okay, I have improved the test as far as I could, but I couldn't squeeze any success out of it… @grevil, maybe you can find what's wrong?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: Unassigned » grevil

We have a 404 which says the URL is not existing.

@grevil: I'd say either the URL is simply wrong (most probable) or any kind of cache issue, which I can't be imagine to be the case... as this must be very dynamic. So I guess there's a bug in the test.

Please replay manually first and simply call the URL via a hard-coded string in the test to see the result.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Assigned: grevil » lrwebks

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented

Nice, the test doesn't fail at line 76 anymore, now it fails at line 86. I will continue there tommorow.

I think the main issues were, that the authorization header was missing and the route builder did not rebuild after we created our content type.

But I'll leave the rest of the changes in as well, so the tests are more in line with the core json_api tests.

grevil’s picture

grevil commented
Assigned: lrwebks » grevil
grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Needs work » Needs review

Ok, that should be it. I'll do some code refactoring in a follow-up issue.

grevil’s picture

grevil commented
Status: Needs review » Reviewed & tested by the community

All green! Merging.

grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.