Problem/Motivation

I ran BigPipeTest locally and got

Exception: Exception: You are not allowed to say llamas are not cool!
Drupal\big_pipe_test\BigPipeTestController::exception()() (Line: 197)

Thought this might be just my local for some reason but @nicxvan and @godotislate both got the same error when they tried it.

Also tried with an unedited clean phpunit.xml.dist copied over what I usually use, and got the same error with that.

I assume this is something to do with phpunit error handling, but don't remember anything specific about that changing.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3556690

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

catch created an issue. See original summary.

quietone’s picture

Fails for me as well. Git bisect reports that 5d387a is the commit where the failure started. That is about CSS not PHPUnit error handling.

catch’s picture

Good plan to use git bisect, I didn't really think this would have been broken by a commit except maybe a phpunit change.

I can confirm that 2999d4574c4, the commit immediately before 5d387a, passes locally for me.

If I revert the system libraries change against 5d387a, this also passes.

However, if I revert the same change against 11.x, that does not help. (!!!!)

That CSS (unless my grep is completely failing) is only used in Claro, which is not used by this test. However, it would be loaded in all functional tests even if it's unused. That combined with a straight revert against 11.x not working makes me wonder if it's not necessarily the specific CSS rules being there or not that was the problem but the file itself or some other bizarre side-effect of that change. And that other changes since then mean that adding back the CSS/file doesn't make the test work again.

Adding a revert MR not because reverting works for me yet, but in case someone is able to confirm that the revert looks correct but also doesn't fix the issue.

catch’s picture

Title: Local test failure - BigPipeTest » [consistent local test failure] - BigPipeTest
Priority: Normal » Critical
Issue tags: +Random test failure

Bumping to critical since this prevents working on the test locally at all, which is how I found it.

catch’s picture

Status: Active » Postponed (maintainer needs more info)

It started working again. Did not bisect yet or anything.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.