Problem/Motivation

No CI scripts for the module.

Steps to reproduce

None.

Proposed resolution

Implement Drupal CI into the module.

Remaining tasks

Configure .gitlab-ci.yml using Drupal templates.

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork custom_search-3556668

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

konot created an issue. See original summary.

konot opened merge request !4

konot’s picture

konot commented
Assigned: konot » Unassigned
Status: Active » Needs review

Hi.

I have added the Drupal CI Templates to the project and resolved as many problems as I could.

However, the only issue is with the PHPStan for a new Drupal version. The issue is that in Drupal 13, the function `node_type_get_names()` would be removed, which is used actively in the project.

I have tried locally to change it by using `\Drupal::service('entity_type.bundle.info')->getBundleLabels('node')`, but faced the issue that the function `getBundleLabels` does not exist in Drupal <=11.2.

But the `node_type_get_names()` should be fine for 10-12 Drupal.

Let me know if there are any adjustments to be made in the scripts :-)

just-me made their first commit to this issue’s fork.

just-me’s picture

just-me commented

Hello,

I've resolved all the warnings in the CustomSearchBlock.php and tested it on Drupal 11.

just-me’s picture

just-me commented
Status: Needs review » Reviewed & tested by the community

Hello,

I've finished testing the module on the Drupal 10 version. It works.

just-me’s picture

just-me commented

Hello,

All changes in the CustomSearchBlock.php file, which are related to warnings, were reverted. It'll be resolved in a separate issue.

Error: Call to a member function getStorage() on null was fixed.

  • loon committed 203fd2c2 on 8.x-1.x authored by konot 
    Issue #3556668: add .gitlab-ci.yml, resolve lints warnings and errors
loon’s picture

loon commented
Status: Reviewed & tested by the community » Fixed

Thanks all, merged

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.