Motivation

#3555905: Optionally leverage previews for progressive rendering supports changing progressive rendering of custom elements.

Proposed resolution

- Improve API response to always render into custom-elements markup when this is requested
- Make sure $element->toRenderArray() is always used so the new setting is picked up.

Issue fork lupus_decoupled-3556418

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago’s picture

fago
Primary language German
Location Vienna
commented
Related issues: +#3561251: Respect lupus-ce-renderer content format when for choosing the right render variant

So the main part is going to happen in #3561251: Respect lupus-ce-renderer content format when for choosing the right render variant. Still, we want to add some test-coverage here that our Views-rendering works correctly with both markup + json formats, to make sure we don't have any regressions here.

fago opened merge request !133

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review

it works with the fix in custom-elements module. The Views-preview was not working as before, I made it use the JSON preview provider - that's fixed but at least works!

Also test coverage is improved to verify the markup output is not using a preview.

  • fago committed 680ecf94 on 1.x 
    fix: #3556418 Fix Views previews and Views custom-elements style to...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.