On a failed payment notification, a DeclineException is thrown which delivers a 500 response code to Payplug. We should avoid that, as done in this commerce_2c2p related issue, by catching this exception and returning a 200 to confirm the notification was correctly managed.

Issue fork commerce_payplug-3556375

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicolasgraph created an issue. See original summary.

nicolasgraph opened merge request !10

nicolasgraph’s picture

nicolasgraph
Primary language French
Location Strasbourg
commented
Assigned: nicolasgraph » Unassigned
Status: Active » Needs review
nicolasgraph’s picture

nicolasgraph
Primary language French
Location Strasbourg
commented
Status: Needs review » Needs work

The response code is now OK but we should also handle de payment entity status to avoid a failed payment to stay new.

nicolasgraph’s picture

nicolasgraph
Primary language French
Location Strasbourg
commented
Status: Needs work » Needs review
nicolasgraph’s picture

nicolasgraph
Primary language French
Location Strasbourg
commented
Title: Avoid sending a 500 response code on failed payment notification » Introduce a better failed payments notification handling
maetvatech’s picture

maetvatech commented
Status: Needs review » Reviewed & tested by the community
nicolasgraph’s picture

nicolasgraph
Primary language French
Location Strasbourg
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.