Remove unused code after switching to off-canvas dialog form

Problem/Motivation

We should now be able to delete swaths of code from Config Enforce and Config Enforce Devel now that we are using an Off-Canvas dialog (or separate page for non-JS users) to manage enforcement settings. See #3188474: Move the config_enforce form to an off-canvas dialog.

This issue is only for Config Enforce Devel. The Config Enforce issue is: #3556298: Remove unused code after switching to off-canvas dialog form.

Proposed resolution

Delete the unused code, make other updates as needed.

Legend

• ❌ = class/method to be deleted
• ✅ = update needed
• ⚠️ = resolution unclear, needs discussion and careful handling
• 📄 = docs updates needed

Classes to deprecate in 1.x, delete in 2.x

• ❌ Drupal\config_enforce_devel\Form\EmbeddedEnforceForm
  • ✅ config_enforce_devel_config_enforce_form_denylist() (referenced by, reference to be removed)
  • ❌ Drupal\config_enforce_devel\FormHandler\ThemeSettingsFormHandlerTrait (used by)
  • 📄 Referenced in inline docs
• ❌ Drupal\config_enforce_devel\Form\ModalEnforceForm
  • ✅ config_enforce_devel_config_enforce_form_denylist() (referenced by, reference to be removed)
• ❌ Drupal\config_enforce_devel\Form\ThemeSettingsFormTrait
  • ❌ Drupal\config_enforce_devel\Form\EmbeddedEnforceForm (used by)
• ❌ Drupal\config_enforce_devel\FormHandler\ThemeSettingsFormHandlerTrait
  • ❌ Drupal\config_enforce_devel\FormHandler\DevelEnforceFormHandler (used by, but code not called, can be removed) - will be removed in #3188474: Move the config_enforce form to an off-canvas dialog

Methods to deprecate in 1.x, delete in 2.x

• ❌ Drupal\config_enforce_devel\FormHandler\DevelEnforceFormHandler::addEnforceForm()

Classes that will be refactored; likely to have methods deprecated in 1.x, deleted in 2.x

(form helper trait updates moved to #3556975: Clean up/refactor DevelFormHelperTrait and ModalFormHelperTrait)

Remaining tasks

• Delete code
• Test manually
• Run automated tests and consider adding more tests
• Deprecate code in 1.0.x branch

User interface changes

Should be none.

API changes

There will be removed classes, methods, etc. which we could mark as deprecated on the 1.0.x branch.

Data model changes

Should be none.