@see https://www.drupal.org/project/drupal/issues/3132758

Issue fork obfuscate_email-3555975

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

pcambra created an issue. See original summary.

pcambra opened merge request !10

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Active » Needs review

I think branch 2.1 should drop D9 support or maybe a 2.2 for this?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

@pcambra thanks! strpos exists since PHP5 so I don't think it needs conditions?

But instead we could now use str_contains, see #3324560: Replace strpos/substr with str_starts_with() / str_contains() / str_ends_with()
What do you think?

Also doesn't need the if, because Drupal 10 requires at least PHP 8.1. PHP 8.1. 6 is recommended!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs work » Needs review

@pcambra I updated the MR accordingly.
Maybe you'd like to apply as co-maintainer in this module?

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented

Not sure how to do that tbh :) but I could adopt it if there's no activity

vishal choudhary’s picture

vishal choudhary
Location Dharmshala
commented
Status: Needs review » Reviewed & tested by the community

I reviewed the code in src/Plugin/Filter/ObfuscateEmail.php.

The change in commit 63fcb9e8 that replaces stripos() / stristr() with str_contains() is working as expected, and I did not find any issues during testing.

Based on my review, this issue can be moved to RTBC.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

@pcambra see https://www.google.com/search?client=firefox-b-d&q=drupal+maintainerhip+...

Thanks @vishal choudhary

  • b_sharpe committed 19fe7efc on 2.1.x authored by pcambra 
    Issue #3555975: Use stripos for mailto detection when available.
b_sharpe’s picture

b_sharpe commented
Status: Reviewed & tested by the community » Fixed

Thanks

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.