Problem/Motivation

The id property is defined with the following lines.

      id:
      type: string
      label: 'ID'
      nullable: true

Since the ID is a machine name, it should be defined using a more specific type: machine_name. This does not change how the property is stored, but it changes how the property is validated.
Furthermore, it does not need to be nullable.

Proposed resolution

Change the schema for the ID to the following one.

      id:
      type: machine_name
      label: 'ID'
Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

avpaderno created an issue. See original summary.

santanu mondal’s picture

Assigned: Unassigned » santanu mondal

santanu mondal’s picture

Assigned: santanu mondal » Unassigned
Status: Active » Needs review
avpaderno’s picture

Status: Needs review » Reviewed & tested by the community

avpaderno’s picture

Version: 3.0.x-dev » 2.1.x-dev
Status: Reviewed & tested by the community » Needs work
avpaderno’s picture

Status: Needs work » Needs review

  • avpaderno committed dbcac67f on 2.1.x
    Issue #3555945: Change the declaration of the ID given in the schema...
avpaderno’s picture

Status: Needs review » Fixed

Thank you for the merge request! I cherry-picked to 2.1.x.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.