Problem/Motivation

\Drupal\Tests\Core\Entity\TypedData\EntityAdapterUnitTest does not set up EntityType::getId() correctly causing deprecations on PHP 8.5.

Steps to reproduce

Run \Drupal\Tests\Core\Entity\TypedData\EntityAdapterUnitTest

Proposed resolution

Set up the mock correctly.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3555885

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !13663

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Thank you @andypost for pointing out ddev just updated with 8.5 so I'm using that now

Ran the test

23 tests triggered 3 PHP deprecations:

1) /var/www/html/core/lib/Drupal/Core/Entity/ContentEntityBase.php:260
Using null as an array offset is deprecated, use an empty string instead

Applied the MR and got 0 deprecations this time.

LGTM.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed 8216fc88 on 11.3.x 
    Issue #3555885 by alexpott, smustgrave: \Drupal\Tests\Core\Entity\...

  • catch committed 3dc5d0e7 on 11.x 
    Issue #3555885 by alexpott, smustgrave: \Drupal\Tests\Core\Entity\...

catch closed merge request !13663

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.