Problem/Motivation

\Drupal\Core\Theme\Icon\IconFinder::extractGroupFromPath() causes PHP 8.5 deprecations.

Steps to reproduce

Run \Drupal\Tests\Core\Theme\Icon\IconFinderTest

Proposed resolution

Fix IconFinder to not trigger deprecations.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3555881

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Parent issue: » #3546535: [meta] Deal with NULL as array key/offset
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

alexpott opened merge request !13659

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Upgraded by ddev to 8.5
Verified without the fix it trigged 1 deprecation
With the MR no deprecations.

catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13659

  • catch committed 86e7dc8b on 11.3.x 
    Issue #3555881 by alexpott: \Drupal\Core\Theme\Icon\IconFinder::...

  • catch committed 00aea85e on 11.x 
    Issue #3555881 by alexpott: \Drupal\Core\Theme\Icon\IconFinder::...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.