Problem/Motivation

\Drupal\Tests\system\Unit\Breadcrumbs\PathBasedBreadcrumbBuilderTest triggers deprecations because config is not mocked correctly.

Steps to reproduce

Run test on PHP 8.5.

Proposed resolution

Mock config correctly.

Remaining tasks

User interface changes

None

Introduced terminology

N/a

API changes

None

Data model changes

None

Release notes snippet

N/a

Issue fork drupal-3555828

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !13656

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
Issue tags: +PHP 8.5
Parent issue: » #3546535: [meta] Deal with NULL as array key/offset
dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

There isn't much to say about this. I verified that the test was failing due to deprecations before now. But the test passes in this pipeline. I verified that the fix is appropriate. The point where the class throws the deprecation error is checking the page.front config key. So if it isn't set properly, then it would return NULL like the failures say. Looks good to me.

catch closed merge request !13656

  • catch committed ac388d4d on 11.3.x 
    Issue #3555828 by alexpott, dcam: \Drupal\Tests\system\Unit\Breadcrumbs\...

  • catch committed f9852e62 on 11.x 
    Issue #3555828 by alexpott, dcam: \Drupal\Tests\system\Unit\Breadcrumbs\...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.