Installing version 1 or 2 of the module on a Drupal 9 site fails with the following error:
This is the error: The website encountered an unexpected error. Please try again later.
Error: Class "Drupal\Core\Render\Element\FormElementBase" not found in include() (line 25 of modules/contrib/commerce_product_review/src/Element/OverallProductRating.php).
FormElementBase in Drupal 9 is not the same as 10+.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
agoradesign commentedok, then we have to remove D9 support from 2.x branch
Comment #3
sleewok commentedI may have it working. The only issue I have now is that the reviews do not show on the product page (using layout builder). How is it supposed to work on layoutbuilder product pages? If I can verify it is working properly we could create a branch with all my code changes for Drupal 9.
I would also suggest having a separate download for version 1 and drupal 9. At some point it worked, but it was changed and that broke drupal 9 support.
Comment #4
agoradesign commentedno idea. I've never ever used layout builder. So I don't know, if it ever worked
Comment #5
rhovlandIt works with Layout Builder. See the readme.md file, known issues section for details on how to make it work. It's also on the project page under Known Issues.
It looks like FormElement is depreciated in favor of FormElementBase and FormElement will be removed in Drupal 12. FormElementBase doesn't exist in Drupal 9.
Since Drupal 9 is no longer supported we will need to drop support for it in 2.x because of this depreciation.
Comment #12
agoradesign commentedComment #18
rhovlandAlso removed Drupal 9 support from 1.x because it's been unsupported for 2+ years. If you're still on 9 then you're already insecure. Supporting it doesn't make sense when Drupal 12 is a couple months away.