Problem/Motivation

DomainServiceProvider contains the following docblock:

/**
 * Overrides the router.route_provider service.
 *
 * Point to our customized one and adds url.site to the
 * required_cache_contexts renderer configuration.
 *
 * @see https://www.drupal.org/node/2662196#comment-10838164
 */

However, it does not override the router.route_provider service

Proposed resolution

Remove the outdated information from the DomainServiceProvider docblock.

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

Issue fork domain-3555760

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !270

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request removes the outdated information from the DomainServiceProvider docblock.

The relevant code has moved to \Drupal\domain\EventSubscriber\DomainSubscriber::onKernelRequestDomain, but it doesn't seem worth mentioning in this particular docblock.

ServiceModifierInterface is already announced in ServiceProviderBase, so it can be removed.

  • mably committed 341e966e on 3.x authored by idebr 
    Issue #3555760 by idebr: DomainServiceProvider contains outdated...
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.