Transition to hook classes

The website encountered an unexpected error. Try again later.

Error: Class "Drupal\mposse\Hook\MposseHooks" not found in Drupal\Component\DependencyInjection\Container->createService() (line 261 of core/lib/Drupal/Component/DependencyInjection/Container.php).

Drupal\Component\DependencyInjection\Container->get() (Line: 197)
Drupal::service() (Line: 70)
mposse_form_node_type_form_alter() (Line: 552)
...

The important things to look at are the legacy hook implementations in the mposse.module file (in particular the service call on line 70, but I imagine they should all have the same problem) and the mposse.services.ymlAm I missing something? I have done several ddev poweroffs and cache rebuilds and Drupal can't seem to find this class

We should also be able to transition from module_implements_alter for manipulating the weight of form alters and just use the hook weights attribute directly: https://www.drupal.org/node/3493962

I'm not sure whether I can implement those attributes while also implementing legacy hooks for backwards compatibility?

I presume we should wait until restricting this module D11.2+

FWIW I tried changing the service name to 'mposse.hooks' and calling the service with that name, and the error didn't change at all

Resolved the fatal error. I just had the hook class file in the wrong location. Ready for more thorough testing.

Tested on Drupal 10.5, everything seems to be working. Still need to test on 11.0 and 11.2+

Modules implementing mposse social platform plugin will need to order their node edit form alter hooks to run after mposse (post 11.2)

Those hook function attributes should be updated to look like:

#[Hook('some_hook', 
  order: new OrderAfter(
    classesAndMethods: [
      [Foo::class, 'someMethod'],
      [Bar::class, 'someOtherMethod'],
    ]
  )
)]

per https://www.drupal.org/node/3493962