Problem/Motivation

On the test file core/modules/media/tests/src/Kernel/OEmbedIframeControllerTest.php the comment has random test file name

  /**
   * Data provider for testBadHashParameter().
   *
   * @return array
   *   An array of test cases.OffCanvasDialogTest.php
   */

Issue fork drupal-3555198

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

vijaycs85 created an issue. See original summary.

vijaycs85 opened merge request !13623

vijaycs85’s picture

vijaycs85
Location London, UK
commented
Status: Active » Needs review
Issue tags: +Novice
quietone’s picture

quietone commented
Version: 11.3.x-dev » 11.x-dev

@vijaycs85, why does this have the 'novice tag'?

astonvictor’s picture

astonvictor commented
Issue tags: -Novice

yeah
make no sense to have the tag

astonvictor’s picture

astonvictor commented

It came from the #3504776: Fix Drupal.Commenting.FunctionComment.MissingReturnComment in extension tests where missing return comments were added. seems it was added by mistake.

astonvictor’s picture

astonvictor commented
Status: Needs review » Reviewed & tested by the community

Since there is no need to add any tests for the issue, we can move it to RTBC.

quietone’s picture

quietone commented
Title: Random test file printed on comment » Remove typo of test file name on comment

@astonvictor, thanks for doing the research. It is good practice to check the history.

  • quietone committed 3d26c657 on 11.3.x 
    Issue #3555198 by vijaycs85, astonvictor: Remove typo of test file name...

  • quietone committed 2b440f85 on 11.x 
    Issue #3555198 by vijaycs85, astonvictor: Remove typo of test file name...
quietone’s picture

quietone commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x and cherry-picked to 11.3.x.

Thanks for the cleanup!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

quietone closed merge request !13623

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.