Problem/Motivation

Spun from #3554905: Livre - evaluate Book 2.0.x with a clean full backport of 3.0.x

See merge request 134

All tests are fully green on

  1. Drupal 11.1.x
  2. Drupal 11.2.x
  3. Drupal 11.3.x

Proposed resolution

See MR 134 one commit

Remaining tasks

Review and test manually.

Issue fork book-3555112

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

joseph.olstad created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Parent issue: » #3554905: Livre - evaluate Book 2.0.x with a clean full backport of 3.0.x

joseph.olstad opened merge request !129

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: Unassigned » joseph.olstad
Status: Needs review » Active

ok going to debug this for 11.1.x

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Active » Needs review
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: Unassigned » joseph.olstad
Status: Needs review » Active

joseph.olstad opened merge request !132

smustgrave’s picture

smustgrave commented
Status: Active » Closed (won't fix)

per my other comment these changes were specific. Bugs can be backported to 2.0.x but new features we will carry forward to 3.0.x

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Closed (won't fix) » Active

This is almost complete, there's only two fails left on D11.1.x and D11.2.x tests are now fully green again other than a minor phpcs.
I'll move this code over to my 2.0.x issue, since all of these fixes and improvements in 3.0.x should be merged into 2.0.x.

I require these fixes for a specific purpose. We cannot upgrade to D11.2.x in the next two weeks and I need this functionality this week.

smustgrave’s picture

smustgrave commented

you can use it as a patch if you want but I don't plan to merge.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

ya, I actually will use the 2.0.x issue instead, can close this.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
Status: Active » Closed (won't fix)

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: Unassigned » joseph.olstad
Category: Support request » Feature request
Status: Closed (won't fix) » Active

Ok I'm down to one test fail , otherwise EVERYTHING is green. I'm quite confident that I'll soon have it 100% green. Straight forward code changes.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Make 3.0.x compatible with Drupal 11.1.8 and fix a bug » Make 3.0.x compatible with Drupal 11.1.8+

joseph.olstad changed the visibility of the branch 3555112-minimal to hidden.

joseph.olstad changed the visibility of the branch 3555112-make-3.0.x-compatible to hidden.

joseph.olstad opened merge request !134

smustgrave’s picture

smustgrave commented

Going to let you keep using this ticket but #12 still stands sorry. Feel free to use as a patch though. Both those tickets are won't fix for me.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented

@smustgrave, it's ok, I can easily fork book using composer replace without renaming the book module which is probably what I will do just as I have done in the past for jquery_ui in jq_ui.

https://a1.11pro.ca/en/public-documentation/drupalorg/dx-composer-replac...

so once the tests are 100% passing , I can close these two issues and continue with the forked project which will be a clone of book however using the replace pattern as documented.

Have a look at jq_ui

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

Houray 100% green!!!! party time!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Assigned: joseph.olstad » Unassigned
Status: Active » Needs review

@smustgrave, prior to me fork/replacing the book module, any feedback on this is appreciated. It's 100% passing, all green!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
smustgrave’s picture

smustgrave commented

I’ll leave these 2 issues open for a week or so but will eventually close out to keep the queue clear for just valid issues

Thanks!

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Issue summary: View changes
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Title: Make 3.0.x compatible with Drupal 11.1.8+ » Make 1.0.x Livre a version of Book 3.0.x that is compatible with Drupal 11.1.8+
Project: Book » Livre
Version: 3.0.x-dev »
Assigned: Unassigned » joseph.olstad
Status: Needs review » Active
joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Version: » 1.0.0-beta2
Assigned: joseph.olstad » Unassigned
Status: Active » Fixed

https://www.drupal.org/project/livre/releases/1.0.0-beta2

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3556111: Make livre 1.0.0-beta3 fully compatible with Drupal 10.5.x

#3556111: Make livre 1.0.0-beta3 fully compatible with Drupal 10.5.x

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Related issues: +#3556109: Replace book module

#3556109: Replace book module

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

smustgrave closed merge request !129

smustgrave closed merge request !132

smustgrave closed merge request !134

joseph.olstad’s picture

joseph.olstad
Primary language French
commented

This commit fixes a regression and ensures the backport solution functions as expected.

https://git.drupalcode.org/project/livre/-/commit/4f54e37d0bf91c8644e9d2...