The DomainNegotiator service can be replaced by the newly introduced DomainNegotiationContext almost everywhere except in the DomainSubscriber service which handles the default domain negotiation in a kernel request event handler.

This will help significantly reduce the risk of circular dependency errors as the DomainNegotiationContext service is a simple object without dependencies nor custom logic.

Issue fork domain-3555067

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

mably created an issue. See original summary.

mably’s picture

Status: Active » Needs review
mably’s picture

Title: Use DomainNegotiationContext in replacement of DomainNegotiator when possible » Replace DomainNegotiator with DomainNegotiationContext wherever possible
mably’s picture

Issue summary: View changes
mably’s picture

Issue summary: View changes

  • mably committed 6d7879bd on 3.x
    Issue #3555067 by mably: Replace DomainNegotiator with...
mably’s picture

Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.