Problem/Motivation

In 1.0.x, core_version_requirement is >=10. It should probably be ^10.0.

Proposed resolution

Set: core_version_requirement: '^10.0'

Remaining tasks

Implement.

User interface changes

None.

API changes

core_version_requirement will be correct.

Data model changes

None.

Issue fork tour-3555046

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

liam morland created an issue. See original summary.

danrod’s picture

danrod
Location Ottawa
commented
Assigned: Unassigned » danrod

danrod opened merge request !130

danrod’s picture

danrod
Location Ottawa
commented
Status: Active » Needs review
danrod’s picture

danrod
Location Ottawa
commented

I applied the change and fixed a DrupalCI warning, there's some CSPELL/PHPCS/PHPSTAN issues that need to be fixed, but this is out of scope of this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Tests are now passing.

smustgrave’s picture

smustgrave commented

Truthfully not maintaining the 1.0x branch

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

It's a very simple fix. As it is, when Drupal 12 comes out, the user could get version 1.0.x.

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Fixed » Needs review

It's not fixed. In the current situation, when Drupal 12 comes out, people may get downgraded from 2.x to 1.x because it claims compatibility. If you don't want to make this simple change, I can be the maintainer for the 1.0.x branch.

smustgrave’s picture

smustgrave commented

I’m just going to drop 1.0.x no fixes go into it and 2.0.x is stable

smustgrave’s picture

smustgrave commented
Status: Needs review » Fixed

All done!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

This ought to stay supported until the Drupal 10 end-of-life, which is just a year from now. There are a lot of changes between 1 and 2. People may not be ready to upgrade. It doesn't take any significant effort. It would have been less work to merge the merge request.

smustgrave’s picture

smustgrave commented

Oh shit I set the MR to auto merge. I can least do that

smustgrave’s picture

smustgrave commented

There you go merged. But leaving the branch unsupported. Forces people to 2.0.x and if any issue gives us an opportunity to fix before 12 is released.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.