Problem/Motivation

Availability default / fallback value is not shown, if none is entered in the product.
As soon as a value is set in the product, it's shown correctly.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork commerce_product_availability-3554608

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

anybody created an issue. See original summary.

grevil made their first commit to this issue’s fork.

grevil’s picture

grevil commented

Should work as expected, from "ProductAvailabilityDefaultFormatter":

    // If the min / max delivery period is empty, we should use the global
    // fallback:
    if ($minDeliveryPeriod === NULL) {
      $minDeliveryPeriod = $this->globalSettings->get('min_delivery_period_fallback');
    }
    if ($maxDeliveryPeriod === NULL) {
      $maxDeliveryPeriod = $this->globalSettings->get('max_delivery_period_fallback');
    }

I need to take a deeper look.

grevil opened merge request !29

grevil’s picture

grevil commented
Assigned: grevil » Unassigned
Status: Active » Needs review

Done, please review!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Great work, RTBC!

  • anybody committed da4f8999 on 1.x authored by grevil 
    [#3554608] feat: Availability default / fallback value is not shown, if...
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.