Problem/Motivation

#3332872: Allow EntityListBuilder::getEntityIds() to easily extend the query introduced a method getEntityListQuery() for ListBuilder classes to easily extend the query. Domain's ListBuilder implementations currently implement getEntityIds() to extend the entity query.

Proposed resolution

Implement EntityListBuilder::getEntityListQuery to alter ListBuilder queries

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork domain-3554246

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !260

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request implements EntityListBuilder::getEntityListQuery to alter ListBuilder queries

mably’s picture

mably commented
Status: Needs review » Needs work

@idebr I added a small comment to your MR.

idebr’s picture

idebr commented
Status: Needs work » Needs review

The merge request is updated with a sort by SORT_KEY for Drupal versions before 10.4.

The call to version_compare is a reminder the statement can be removed once 10.4 is no longer supported by Domain

  • mably committed b89d4fe4 on 3.x authored by idebr 
    Issue #3554246: Implement EntityListBuilder::getEntityListQuery to alter...
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.