Problem/Motivation

Controllers that extend ControllerBase cannot promote the properties defined in ControllerBase.

The documentation for ControllerBase suggests it is used for simple cases only, so it might be worth dropping the base class to improve maintainability

Proposed resolution

Remove ControllerBase for complex use cases

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

Issue fork domain-3554044

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !257

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request removes ControllerBase for complex use cases

mably made their first commit to this issue’s fork.

  • mably committed 63188ac2 on 3.x authored by idebr 
    Issue #3554044 by idebr: Remove ControllerBase for complex use cases
mably’s picture

mably commented
Status: Needs review » Fixed

Merged! Thanks @idebr.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.