I need to add to my request SAML a specific AuthnContextClassRef with Comparison set to minimum.
Something like:
<samlp:RequestedAuthnContext Comparison="minimum">
<saml:AuthnContextClassRef>
urn:qoa.my.custom.namespace:names:tc:ac:classes:20
</saml:AuthnContextClassRef>
</samlp:RequestedAuthnContext>
I don't think it's a good idea to try to add an UI for this kind of use case but it would be nice if the plugin add an extension point to let developer set pass/override custom settings to the underlying SAML library.
I don't have the full overview of the module but I suspect a good candidate is to hook into Drupal\samlauth\SamlService::getSamlAuth($purpose = '', $initialize = TRUE).
As I need this quickly, I will propose a patch and we can start the discussion on it.
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
wengerkLooks good to me!
One alternative approach to consider would be implementing an OOP Hook Alter (see https://www.drupal.org/node/3442349). However, from my perspective, using an event subscriber versus a hook implementation are functionally equivalent for this use case, so either approach works well.
Comment #5
roderikThank you for a very complete MR (with README, comments and tests).
I don't have a strong opinion about OOP hooks vs event subscribers. I'll likely start switching back to using OOP hooks more, in general... but since this module doesn't use them yet and the hook isn't going to be super commonly used... no reason for me to change the MR.
The only thing I've done is change the assertion messages to be consistent with what's being done in this module. (They are technically 'error mesages', and IMHO should not say "X happened" on an assertion that X happened -> are printed when _did not_ happen).
...plus sneak in a fix to a PHPunit deprecation warning that just popped up in Gitlab...
Comment #7
roderik