Problem/Motivation

While working on #3551650: Decouple text_with_summary from tests but not migrations there were a number of migration related tests found and was requested to move to their own ticket.

Following where ones I found

core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldInstanceTest.php
core/modules/field/tests/src/Kernel/Migrate/d7/MigrateFieldTest.php
core/modules/field/tests/src/Kernel/Plugin/migrate/source/d7/FieldInstancePerFormDisplayTest.php
core/modules/field/tests/src/Kernel/Plugin/migrate/source/d7/FieldInstancePerViewModeTest.php
core/modules/field/tests/src/Kernel/Plugin/migrate/source/d7/FieldInstanceTest.php
core/modules/field/tests/src/Kernel/Plugin/migrate/source/d7/ViewModeTest.php
core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeRevisionTest.php
core/modules/node/tests/src/Kernel/Migrate/d6/MigrateNodeTest.php

My first thought was to clone these tests and place in the text module to be copied to the soon to be created/deprecated text_with_summary_field module. Then update these to not check for summary at all in the original.

Steps to reproduce

NA

Proposed resolution

No changes to migrations or migration tests.

Remaining tasks

Decide what needs to be done
Update title
Implement
Review

User interface changes

NA

Introduced terminology

NA

API changes

NA

Data model changes

NA

Release notes snippet

NA

Comments

smustgrave created an issue. See original summary.

quietone’s picture

quietone commented

I think it would be fine if we continue to migrate into the deprecated field, then the field itself could only be removed in Drupal 13 at this point, and migrate_drupal will already have been removed in Drupal 12 at that point.

From catch at #3427095-19: [Meta] Deprecate text_with_summary

That seems reasonable to me. Following that, for Drupal 11 migration tests do not need to be changed. And any migration tests for the new field would then be done in a contrib module. I will double check with the other release managers.

quietone’s picture

quietone commented
Issue summary: View changes
Status: Active » Needs review

I did talk to confirm this with catch a few weeks ago. Finally coming back to write that up. The short answer is that nothing should change for the migrations.

So, if a legacy site migrates to Drupal 11, and text_with_summary is deprecated, the migration will still work. Then, after the migration, such a site can choose to use a contrib module that provides text_with_summary. The migration has already happened so the contrib module does not need to supply the migration or test it. Of course, such a site may just upgrade to Drupal 12 which should be providing an upgrade path for text_with_summary.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

So we have to wait till 13 to deprecate this plugin because this one blocker? Seems extreme

But some of the tests listed in the field module, example FieldInstancePerFormDisplayTest, aren't using the migrate fixtures but was told can't update those so what to do with those?

smustgrave’s picture

smustgrave commented
Status: Needs work » Fixed

Talked in slack and think this can be closed. Credited catch and quietone from #3

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.