Problem/Motivation

While working on #3551650: Decouple text_with_summary from tests but not migrations was requested to move the schema change to it's own ticket. The change is needed because switching to textarea from text_with_summary the placeholder type changes from text to label. This breaks a validation multi-line test because type label doesn't allow multi-lines.

Steps to reproduce

Proposed resolution

Change the type to be text just like the placeholder for text_with_summary

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3553853

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

smustgrave created an issue. See original summary.

smustgrave’s picture

smustgrave commented
Issue summary: View changes

smustgrave opened merge request !13556

smustgrave’s picture

smustgrave commented
Status: Active » Needs review
amateescu’s picture

amateescu commented
Status: Needs review » Needs work

Left some feedback.

smustgrave’s picture

smustgrave commented
Status: Needs work » Needs review

So I actually got the wrong test but took the feedback from that one to the correct one.

smustgrave’s picture

smustgrave commented

Revert the previous test but ran the test-only job https://git.drupalcode.org/issue/drupal-3553853/-/jobs/6994061

amateescu’s picture

amateescu commented
Assigned: smustgrave » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good to me now :)

  • catch committed 7aeffa40 on 11.3.x 
    Issue #3553853 by smustgrave, amateescu: Change placeholder type for...

  • catch committed 219b00ec on 11.x 
    Issue #3553853 by smustgrave, amateescu: Change placeholder type for...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13556

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.