Problem/Motivation

The phpcs pipeline job is failing, see for example https://git.drupalcode.org/issue/content_lock-3441684/-/pipelines/635051

Proposed resolution

Fix phpcs pipeline job findings

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

Issue fork content_lock-3553633

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

klausi made their first commit to this issue’s fork.

klausi opened merge request !101

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Title: Fix phpcs findings in pipeline » Fix phpcs, phstan and deprecation findings in pipeline
Status: Active » Needs review

Ready for review, I did not understand how to fix all deprecation warnings, but tests are green now.

aurelianzaha’s picture

aurelianzaha commented
Status: Needs review » Reviewed & tested by the community

thanks for the fix @klausi

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

I don't think block_content_add_body_field() should be removed until support for Drupal 10 is removed. Version 3.0.x should be for Drupal 10 and 11, where block_content_add_body_field() still exists. Version 3.1.x could be for Drupal 11 and 12 and BodyFieldCreationTrait can be used instead. It is better to directly replace the function with the trait replacement instead of going through the intermediate step of a custom function.

  • alexpott committed a5dbab4e on 3.x 
    task: #3553633 Fix phpcs, phstan and deprecation findings in pipeline...
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Nice to come to the issue queue and fix this done. Thanks everyone!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

alexpott closed merge request !101

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.