Problem/Motivation

Currently, the last parameter ($options), expects a library API-specific array that gets passed to the Chart element's "#raw_options" key - this goes against the flexible spirit of Charts, which should allow users to easily switch between libraries.

Proposed resolution

The better approach would be to pass a single $definition parameter that contains all the charts settings (and is more flexible) plus any raw options. But we should do this in a way that maintains backward compatibility.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork charts_twig-3553513

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andileco created an issue. See original summary.

andileco opened merge request !11

andileco’s picture

andileco commented
Assigned: andileco » nikathone
Status: Active » Needs review

@nikathone, can you take a look?

andileco’s picture

andileco commented
Issue summary: View changes

nikathone made their first commit to this issue’s fork.

andileco’s picture

andileco commented
Status: Needs review » Reviewed & tested by the community

Thank you, @nikathone! I like that you make it work with the original function. I'm happy with this and the code quality checks pass.

andileco’s picture

andileco commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.