Problem/Motivation

A domain is deleted through a custom \Drupal\domain\Form\DomainDeleteForm. However, this form does not list the configuration that will be changed upon deletion.

Proposed resolution

Use \Drupal\Core\Entity\EntityDeleteForm to delete a domain record

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

To be determined.

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 3553403-before.png56.19 KBidebr
#2 3553403-after.png105 KBidebr

Issue fork domain-3553403

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr’s picture

idebr commented
Status: Active » Needs review
StatusFileSize
new 3553403-after.png105 KB
new 3553403-before.png56.19 KB

The merge request implements the following changes:

  1. The domain delete form is now generated through \Drupal\Core\Entity\EntityDeleteForm
  2. The entity.domain.collection route is added as an alias of domain.admin to match the expectations of \Drupal\Core\Entity\EntityDeleteForm

Before

before

After

after

idebr opened merge request !256

mably’s picture

mably commented
Status: Needs review » Needs work

Tests are failing.

idebr’s picture

idebr commented
Status: Needs work » Needs review

The test assertion with the successful deletion message has been updated in the merge request

mably’s picture

mably commented
Status: Needs review » Needs work

Looks like tests are still failing.

idebr’s picture

idebr commented
Status: Needs work » Needs review

Turns out a route alias is Drupal 11.x only

The cancel URL is restored in the delete form, so no route changes are required.

mably’s picture

mably commented

Thanks @idebr, this is a nice improvement. Let's merge it.

  • mably committed 01cc43af on 3.x authored by idebr 
    Issue #3553403 by idebr: Use \Drupal\Core\Entity\EntityDeleteForm to...
mably’s picture

mably commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • mably committed 890f4f79 on topic/use-entity-delete-form authored by idebr 
    Issue #3553403 by idebr: Use \Drupal\Core\Entity\EntityDeleteForm to...

  • mably committed 890f4f79 on 2.0.x authored by idebr 
    Issue #3553403 by idebr: Use \Drupal\Core\Entity\EntityDeleteForm to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.