Problem/Motivation

There are no usages of \Drupal\views\Plugin\views\argument\Date::$option_name.

Steps to reproduce

Search for usages and none are returned.

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3553348

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !13540

quietone’s picture

quietone commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Pretty straight forward, also came here from #3478812: Remove phpcs:ignore VariableComment.Missing

poker10’s picture

poker10 commented
Status: Reviewed & tested by the community » Needs review

The plugins are not considered a public API, but I am curious if we should deprecate it first as per https://www.drupal.org/about/core/policies/core-change-policies/how-to-d... anyway? It is also a public property which could probably be used in some contrib modules/custom code (even though I have not found any evidence for that so far). Thanks!

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

That's fair. It is a view plugin so very well could be getting used by a custom module (not sure why though). Nice catch!

quietone’s picture

quietone commented
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +Needs subsystem maintainer review

I think we should actually search for usages before deciding on adding BC. I thought I had added it but is seems I did not. I have now updated the issue summary which finds no usages of this property.

And let's check with the subsystem maintainer.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Issue tags: -Needs subsystem maintainer review

I feel this setting is related to arguments being able to provide their own defaults, but see #2325899: UI fatal caused by views argument handlers no longer being able to provide their own default argument handling, that has been broken/removed since before 8.0.0. But as that issue shows, this argument plugin has other dead code in it, and I think this property is part of that.
I feel it's safe to remove this.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

So, I'd say RTBC

  • catch committed 6f10e712 on 11.x 
    Issue #3553348 by quietone, lendude: Remove unused class property \...

  • catch committed b20a5e5e on 11.3.x 
    Issue #3553348 by quietone, lendude: Remove unused class property \...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Yes this looks like properly dead code. Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

catch closed merge request !13540

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.