Problem/Motivation

Tests are not passing due to PHP warnings.

Steps to reproduce

Run tests on gitlab

Proposed resolution

Fix them

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

Issue fork potx-3553345

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alexpott created an issue. See original summary.

alexpott opened merge request !35

alexpott opened merge request !36

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

The problem only exists on the 8.x branch - the 7.x branch is passing - see https://git.drupalcode.org/project/potx/-/merge_requests/36.

alexpott changed the visibility of the branch 3553345-fix-tests-7.x-3.x to hidden.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review

To actually fix the tests we need to land #3528177: Potx doesn't recognize t filters and dots in variables as of twig 3.21 too... but this unblocks stuff by reducing noise.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Needs review » Fixed

Merged !35

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.