Problem/Motivation

When users have been blocked, they still get notifications.

Steps to reproduce

Proposed resolution

Blocked users should not get notifications.

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork group_notify-3553216

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

edvanleeuwen created an issue. See original summary.

dww’s picture

dww
we/he/they
commented
Category: Feature request » Bug report

Thanks for the report! This sounds more like a bug report than a feature request to me. 😅 I'd be willing to put this in both 8.x-1.x and 2.0.x branches.

ritarshi_chakraborty’s picture

ritarshi_chakraborty commented

Working on it.

ritarshi_chakraborty opened merge request !8

ritarshi_chakraborty’s picture

ritarshi_chakraborty commented
Status: Active » Needs review
dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

Perfect, thanks! That's exactly what I was thinking was needed, and where the check should go.

Normally, I'd ask for test coverage, but since this project basically has no automated tests (see #3164923: [META] Add test coverage for Group Notify if you want to help with that), I'm not going to hold this up. 😅

I started a merge via GitLab, so it should post here soon.

Thanks again!
-Derek

dww’s picture

dww
we/he/they
commented
Status: Reviewed & tested by the community » Fixed

Merged to 8.x-1.x, cherry-picked to 2.0.x.

Thanks!
-Derek

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

ritarshi_chakraborty’s picture

ritarshi_chakraborty commented

Hi @dww, thanks for approving the MR!

I just wanted to kindly mention that the credit attribution might have been missed. As a new contributor, getting credited would mean a lot and help keep me motivated to continue contributing to the Drupal community.

edvanleeuwen’s picture

edvanleeuwen
Primary language Dutch
Location Waalwijk
commented

Thanks for solving this, @ritarshi_chakraborty!

dww’s picture

dww
we/he/they
commented

Weird, I had saved the contribution record. Absolutely meant to credit you. But apparently it reset itself once I marked this fixed? Anyway, just re-saved it.

ritarshi_chakraborty’s picture

ritarshi_chakraborty commented

I’ve received the credit—thanks for that! Happy to have contributed and helped fix the issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.