Problem/Motivation

The form classes and the other entity classes are not supposed to be used from other modules as base classes.

Proposed resolution

Mark the following classes internal.

  • Drupal\user_restriction\Form\RestrictionDisableForm
  • Drupal\user_restriction\Form\RestrictionEnableForm
  • Drupal\user_restriction\Form\UserRestrictionsAddForm
  • Drupal\user_restriction\Form\UserRestrictionsDeleteForm
  • Drupal\user_restriction\Form\UserRestrictionsEditForm
  • Drupal\user_restriction\Form\UserRestrictionsFormBase
  • Drupal\user_restriction\UserRestrictionsListBuilder
  • Drupal\user_restriction\UserRestrictionsManager
  • Drupal\user_restriction\UserRestrictionTypeManager

Issue fork user_restrictions-3553130

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

avpaderno created an issue. See original summary.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Title: Mark as internal the form classes used for user restriction entity » Mark as internal the form and the entity classes
Issue summary: View changes

avpaderno opened merge request !73

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Active » Needs review

  • avpaderno committed 43fa7937 on 3.0.x 
    Issue #3553130: Mark as internal the form and the entity classes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 3.0.x-dev » 2.1.x-dev

avpaderno opened merge request !74

  • avpaderno committed 4b300eba on 2.1.x 
    Issue #3553130: Mark as internal the form and the entity classes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Version: 2.1.x-dev » 2.0.x-dev

avpaderno opened merge request !81

  • avpaderno committed e711467b on 2.0.x 
    Issue #3553130: Mark as internal the form and the entity classes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented

This change has been back ported to the 2.0.x to give it more visibility. I cannot say how much contributed or custom modules implements user restriction plugins, but I would like this is to be a well visible change.

This change will be disruptive only on the 4.0.x, as the old classes will no longer be available. Hopefully, there will be enough time before that.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.