Problem/Motivation

The database icon in Navigation isn't the one from the Phosphor library so it doesn't match the others. We are using it in Canvas as of #3548064: Add a link to the Pages view to the administration menu and rename Content link.

Steps to reproduce

N/A

Proposed resolution

Update the SVG.

Remaining tasks

N/A

User interface changes

Updates the icon to match the others.

Before:

After:

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3553091

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

pameeela created an issue. See original summary.

pameeela’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new27.9 KB
new27.67 KB
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Seems straight forward. Working off the screenshots provided

quietone’s picture

Status: Reviewed & tested by the community » Needs review

Working off the supplied images doesn't truly review the change though.

I don't have that icon showing in the navigation. How to enable it?

pameeela’s picture

I don’t think the icon is currently being used in core, so there is no change really to review. We’ve opted to use it as part of a change that will be introduced in Canvas. So I’m not sure how it could be tested in place.

You could update one of the existing link classes in your browser with a before and after but since there is no core change I think just comparing the files is enough?

quietone’s picture

Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new3.71 KB

@pameeela, thanks. I followed your advice and this screenshots shows the current database image for 'Content' and the new one for 'Files' and thus confirms this change.

nod_’s picture

Status: Reviewed & tested by the community » Fixed

Committed 0403e05 and pushed to 11.x. Thanks!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • nod_ committed 0403e057 on 11.x
    Issue #3553091 by pameeela, quietone: Update database icon to use...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.