Problem/Motivation

For some reason, chrome isn't providing that info for me. But it's not needed anyway without an OTEL_COLLECTOR, so lets only wait for it if we're going to be using it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3552907

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

berdir opened merge request !13521

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

So I'm sure these fluctuate but compared this run to the last run from HEAD

Javascript #1 3 min 27 sec compared to 3 min 41 sec
Javascript #2 3 min 7 sec compared to 5 min 12 sec
Javascript #3 3 min 34 sec compared to 2 min 53 sec

So definitely improvement in 2/3 of the runs. The #3 may have been an outlier since there's such a difference in #2

Going to mark as a net improvement.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

This shouldn't result in a measurable difference *under normal circumstances*. At most it would maybe be a second here and there if we don't have to wait another second. But if your browser is somehow acting up like mine does then it makes a huge difference and it's ~30s faster per profiled request.

catch closed merge request !13521

  • catch committed 58d78289 on 11.3.x 
    Issue #3552907 by berdir: PerformanceTestTrait waits up to 30s for LCP...

  • catch committed 391e99db on 11.x 
    Issue #3552907 by berdir: PerformanceTestTrait waits up to 30s for LCP...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 11.3.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.