Problem/Motivation
This summary was updated based on #3552894-10: Fix typos in comments to core.services.yml and serialization.yaml to also include other typos.
The initial summary and fix only covered the DrupalKernel comment
Nitpick of the day:
There is a some comments in Drupal core that reference non-existing files or services
- reference to a non-existing file in the class comment of \Drupal\Core\DrupalKernel
- reference to a non-existing service in 2 Twig related classes
Steps to reproduce
- the file extension is wrong in
- web/core/lib/Drupal/Core/DrupalKernel.php
* CoreServiceProvider, which, in addition to registering any core services that
* cannot be registered in the core.services.yaml file, adds any compiler passes - the service name is wrong in
- core/modules/help/src/HelpTopicTwigLoader.php
- core/lib/Drupal/Core/Template/TwigEnvironment.php (2 times)
// Note: always use \Drupal\Core\Serialization\Yaml here instead of the
// "serializer.yaml" service. This allows the core serializer to utilize
Proposed resolution
-
* CoreServiceProvider, which, in addition to registering any core services that
* cannot be registered in the core.services.yml file, adds any compiler passes -
// Note: always use \Drupal\Core\Serialization\Yaml here instead of the
// "serialization.yaml" service. This allows the core serializer to utilize
Remaining tasks
none
User interface changes
none
Introduced terminology
none
API changes
none
Data model changes
none
Release notes snippet
none
Issue fork drupal-3552894
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
mollux commentedComment #3
mollux commentedComment #7
mollux commentedComment #8
mollux commentedComment #9
smustgrave commentedThanks for finding. MR needs to be pointed to 11.x
Also would be good to search if there are other instances of this typo
Comment #10
mollux commentedSomehow I can't create an MR for 11.x, the button doesn't appear. Do I lack permissions to create the MR?
I checked the source code, and there are some occurrences:
* The first one is addressed in this PR
* the next ones are actually another typo: the services name is serialization.yaml, but is mentioned in the comments as serializer.yaml.
Do I change those in the PR (and change title and description)?
Comment #12
smustgrave commentedThe current MR you have you should be able to change the target branch.
You will have to rebase though as 11.2.x and 11.x are very different
Comment #13
smustgrave commentedShould have mentioned 11.x is the development branch for core. So things need to land there first. And depending on what they are it’ll backported
Comment #16
mollux commentedI changed the MR to target 11.x
Comment #18
mollux commentedComment #19
mollux commentedComment #20
smustgrave commentedCan you fix the phpcs error?
Comment #21
smustgrave commentedThese look correct to me. Thanks!
Comment #22
quietone commentedFix typos in comments to core.services.yml and serialization.yaml
Comment #23
quietone commentedI applied the diff and searched for remaining instances and found none.
Comment #25
quietone commentedCommitted 8d09052 and pushed to 11.x. Thanks!