Problem/Motivation

I'm using schema metatag along with the new Drupal Canvas module. When I try to save the page in Drupal Canvas I always get the following error:

The submitted value <em>0</em> in the <em>Pivot </em>element is not allowed.

This happens for all instances of the pivot select field. I would have to edit every pivot field for every page.

Steps to reproduce

Install Drupal Canvas
Install Metatag
Install Schema Metatag
Create a page in Drupal Canvas
Save the page

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork schema_metatag-3552529

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

eric heydrich created an issue. See original summary.

mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented

Duplicated issue with additional information: #3569381: Canvas pages fail to save (with error) if schema_article module installed

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Related issues: +#3569381: Canvas pages fail to save (with error) if schema_article module installed
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented

\Drupal\schema_metatag\Plugin\schema_metatag\PropertyTypeBase::form does

$value_sub_property = $input_values['value'][$sub_property_name]['pivot'] ?? 0;

and that's a select, with only

      '#options' => [
        1 => $this->t('Pivot'),
      ],

and 

     '#empty_value' => '',

penyaskito opened merge request !103

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Issue tags: +Experience Builder
mherchel’s picture

mherchel
he/him
Primary language English
Location Gainesville, FL, US
commented
Status: Needs review » Reviewed & tested by the community

Worked for me! Note I had to re-create the Canvas page though. Thank you!

thejimbirch’s picture

thejimbirch commented
Status: Reviewed & tested by the community » Fixed

Merge train started. Thanks for the finding and fix!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

thejimbirch’s picture

thejimbirch commented
Status: Fixed » Active
interx’s picture

interx commented

Thanks! The fix works for me on new edits.
Note, I had to discard already staged changes and recreate them to get rid of the errors.

thejimbirch’s picture

thejimbirch commented
Status: Active » Fixed

Fixed the issue with the tests and started the merge train.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: » #3574331: (dupe) Plan for Schema Metatag 3.0.4
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Parent issue: #3574331: (dupe) Plan for Schema Metatag 3.0.4 » #3461812: Plan for Schema.org Metatag 3.0.4