Problem/Motivation

The Authorization header field in the webform settings is currently a textfield. Textfields have a default maxlength of 128 chars.
These header tokens can be pretty long.

Steps to reproduce

Add a long (>128 chars) bearer token in the field, the form gives the error

 Authorization header to connect to OpenFisca API cannot be longer than 128 characters but is currently 283 characters long.

Proposed resolution

Change the form field to be a textarea

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork webform_openfisca-3551968

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

gargsuchi created an issue. See original summary.

gargsuchi opened merge request !9

sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented

The MR failed both PHPCS and PHPUnit tests:

FILE: tests/modules/webform_openfisca_test/src/OpenFiscaTestClientMiddleware.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 116 | ERROR | String concat is not required here; use a single string instead
     |       | (Generic.Strings.UnnecessaryStringConcat.Found)
------------------------------------------------------------------------------------------------------------------------

There was 1 failure:
1) Drupal\Tests\webform_openfisca\Kernel\WebformThirdPartySettingsFormAlterKernelTest::testWebformThirdPartySettingsFormAlter
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'textfield'
+'textarea'
sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented
Status: Active » Needs work

  • sonnykt committed 54953c25 on 1.x authored by gargsuchi 
    [#3551968] feat: Changed the field type to textarea instead of textfield...

  • sonnykt committed 54953c25 on 1.0.x authored by gargsuchi 
    [#3551968] feat: Changed the field type to textarea instead of textfield...
gargsuchi’s picture

gargsuchi commented
Status: Needs work » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

sonnykt’s picture

sonnykt
Location Melbourne, Australia
commented
Status: Fixed » Closed (fixed)

Released with 1.0.1