Problem/Motivation

part of #3523596: [meta] PHP 8.5 support

Symfony used to update compatibility for 6.x/7.x branches via https://github.com/symfony/symfony/issues/61772

Steps to reproduce

composer update symfony/* -W

Proposed resolution

update symfony with dependencies to latest version

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3551569

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

andypost created an issue. See original summary.

andypost opened merge request !13458

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Active » Needs review

changes

+----------------------------------+---------+---------+
| Production Changes               | From    | To      |
+----------------------------------+---------+---------+
| doctrine/deprecations            | 1.1.5   | REMOVED |
| doctrine/lexer                   | 2.1.1   | 3.0.1   |
| masterminds/html5                | 2.9.0   | 2.10.0  |
| symfony/console                  | v7.3.0  | v7.3.4  |
| symfony/dependency-injection     | v7.3.0  | v7.3.4  |
| symfony/error-handler            | v7.3.0  | v7.3.4  |
| symfony/event-dispatcher         | v7.3.0  | v7.3.3  |
| symfony/filesystem               | v7.3.0  | v7.3.2  |
| symfony/finder                   | v7.3.0  | v7.3.2  |
| symfony/http-foundation          | v7.3.0  | v7.3.4  |
| symfony/http-kernel              | v7.3.0  | v7.3.4  |
| symfony/mailer                   | v7.3.0  | v7.3.4  |
| symfony/mime                     | v7.3.0  | v7.3.4  |
| symfony/polyfill-ctype           | v1.32.0 | v1.33.0 |
| symfony/polyfill-iconv           | v1.32.0 | v1.33.0 |
| symfony/polyfill-intl-grapheme   | v1.32.0 | v1.33.0 |
| symfony/polyfill-intl-idn        | v1.32.0 | v1.33.0 |
| symfony/polyfill-intl-normalizer | v1.32.0 | v1.33.0 |
| symfony/polyfill-mbstring        | v1.32.0 | v1.33.0 |
| symfony/polyfill-php84           | v1.32.0 | v1.33.0 |
| symfony/polyfill-php85           | v1.32.0 | v1.33.0 |
| symfony/process                  | v7.3.0  | v7.3.4  |
| symfony/routing                  | v7.3.0  | v7.3.4  |
| symfony/serializer               | v7.3.0  | v7.3.4  |
| symfony/string                   | v7.3.0  | v7.3.4  |
| symfony/validator                | v7.3.0  | v7.3.4  |
| symfony/var-dumper               | v7.3.0  | v7.3.4  |
| symfony/var-exporter             | v7.3.0  | v7.3.4  |
| symfony/yaml                     | v7.3.0  | v7.3.3  |
+----------------------------------+---------+---------+

+-----------------------+--------+--------+
| Dev Changes           | From   | To     |
+-----------------------+--------+--------+
| symfony/browser-kit   | v7.3.0 | v7.3.2 |
| symfony/dom-crawler   | v7.3.0 | v7.3.3 |
| symfony/lock          | v7.3.0 | v7.3.4 |
| doctrine/deprecations | NEW    | 1.1.5  |
+-----------------------+--------+--------+

andypost opened merge request !13459

andypost’s picture

andypost
he/him
Primary language Russian
commented

filed another MR without deps as 2 tests fail and and probably masterminds is the cause

+-----------------------+-------+---------+
| Production Changes    | From  | To      |
+-----------------------+-------+---------+
| doctrine/deprecations | 1.1.5 | REMOVED |
| doctrine/lexer        | 2.1.1 | 3.0.1   |
| masterminds/html5     | 2.9.0 | 2.10.0  |
+-----------------------+-------+---------+

+-----------------------+------+-------+
| Dev Changes           | From | To    |
+-----------------------+------+-------+
| doctrine/deprecations | NEW  | 1.1.5 |
+-----------------------+------+-------+

errors are

    Image Url Provider (Drupal\Tests\ckeditor5\FunctionalJavascript\ImageUrlProvider)
     ✔ Alt text required with Restricted
     ✔ Alt text required with Unrestricted
     ✔ Alignment with Block·image
     ✔ Alignment with Inline·image
     ✘ Width with Image·resize·with·percent·unit·(only·allowed·in·HTML·4)
       ┐
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'33%'
       ┊ +'88'
       │
       │ /builds/issue/drupal-3551569/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php:231
       ┴
     ✘ Width with Image·resize·with·(implied)·px·unit
       ┐
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'100'
       ┊ +'88'
       │
       │ /builds/issue/drupal-3551569/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php:231
       ┴

and 

Image Test Provider (Drupal\Tests\ckeditor5\FunctionalJavascript\ImageTestProvider)
     ✔ Alt text required with Restricted
     ✔ Alt text required with Unrestricted
     ✔ Alignment with Block·image
     ✔ Alignment with Inline·image
     ✘ Width with Image·resize·with·percent·unit·(only·allowed·in·HTML·4)
       ┐
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'33%'
       ┊ +'40'
       │
       │ /builds/issue/drupal-3551569/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php:231
       ┴
     ✘ Width with Image·resize·with·(implied)·px·unit
       ┐
       ├ Failed asserting that two strings are identical.
       ┊ ---·Expected
       ┊ +++·Actual
       ┊ @@ @@
       ┊ -'100'
       ┊ +'40'
       │
       │ /builds/issue/drupal-3551569/core/modules/ckeditor5/tests/src/FunctionalJavascript/ImageTestProviderTrait.php:231
       ┴
andypost’s picture

andypost
he/him
Primary language Russian
commented

doctrine/lexer could use update separate issue as its dependency doctrine/deprecations going to require-dev
https://github.com/doctrine/lexer/blob/3.0.x/UPGRADE.md

Doctrine\Common\Lexer\Token no longer implements ArrayAccess. Parameter type declarations have been added to Doctrine\Common\Lexer\AbstractLexer and Doctrine\Common\Lexer\Token. You should add both parameter type declarations and return type declarations to your lexers, based on the @return phpdoc.

the breaking change in masterminds/html5 2.10 breaks 2 tests #5

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs review » Needs work
Issue tags: +Vienna2025

discussed with Alexpott and we decided to split it for SF, masterminds and doctrine

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@andypost see #3552765-7: Update Composer dependencies for 11.3.0 for reasons why masterminds/html5 breaks tests, probably a duplicate of that issue?

andypost’s picture

andypost
he/him
Primary language Russian
commented

@longwave yes, so curious as @alexpott asked to split deprecations move into separate issue

andypost’s picture

andypost
he/him
Primary language Russian
commented
Status: Needs work » Closed (duplicate)

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

andypost’s picture

andypost
he/him
Primary language Russian
commented
Related issues: +#3552765: Update Composer dependencies for 11.3.0

Superseded by #3552765: Update Composer dependencies for 11.3.0

andypost closed merge request !13459

andypost closed merge request !13458