Problem/Motivation

The module has no CI, so nothing checks a change before it is merged: no PHPCS, no PHPStan, no ESLint, no Stylelint, no spell check and no upgrade status against the next Drupal major.

Steps to reproduce

  1. Open a merge request on the project.
  2. No pipeline runs.

Proposed resolution

Add the Drupal GitLab CI templates, opt into the previous major, previous minor, next minor, next major and max PHP jobs, run upgrade status, and keep a project word list for the spell check. The lint findings that this brings up are fixed in the same change, and the module now declares Drupal 12 support.

The widget on the Arabic right to left form after the style clean up

Remaining tasks

  • ✅ File an issue
  • ✅ Addition/Change/Update/Fix
  • ✅ Testing to ensure no regression
  • ➖ Automated unit testing coverage
  • ➖ Automated functional testing coverage
  • ➖ UX/UI designer responsibilities
  • ✅ Readability
  • ➖ Accessibility
  • ➖ Performance
  • ➖ Security
  • ➖ Developer Documentation
  • ➖ User Guide Documentation
  • ➖ Reviewed by human
  • ➖ Code review by maintainers
  • ➖ Full testing and approval
  • ➖ Credit contributors
  • ➖ Review with the product owner
  • ➖ Release notes snippet
  • ❌ Release

User interface changes

  • N/A

API changes

  • N/A

Data model changes

  • N/A

Release notes snippet

  • Autocomplete Deluxe now runs the Drupal GitLab CI pipeline on every merge request, and declares support for Drupal 12.
CommentFileSizeAuthor
#4 3551487-arabic-rtl-widget.png83.04 KBrajab natshah

Issue fork autocomplete_deluxe-3551487

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

konot created an issue. See original summary.

konot opened merge request !29

konot’s picture

konot commented
Assigned: konot » Unassigned
Status: Active » Needs review

I have implemented the CI based on Drupal GitLab CI templates.

I have resolved issues reported by lints; however, I have removed the Eslint and StyleLint config files in the MR !29, as both Eslint and Stylelint are not working correctly with them. It is actually a reported issue in the GitLab Templates project (https://www.drupal.org/project/gitlab_templates/issues/3438843).

I have compared both of those configs with default cores, and they are quite the same, and there were no specific problems in the code which I have been unable to resolve without using inline comments to ignore some issues (like ignoring the gulpfile).

For now, the CI is fully working and all errors are resolved; the CI is fully green.

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: Unassigned » rajab natshah
Issue summary: View changes
StatusFileSize
new 3551487-arabic-rtl-widget.png83.04 KB

Thank you, Artem for setting the pipeline up and for cleaning the lint findings along the way.

The pipeline is green on all fifteen jobs, including PHPStan and upgrade status on the next major.

Checked the style clean up in a browser on Drupal 11.4, since a good part of the change is CSS: the widget behaves and looks the same in Claro, the suggestion list and the tags are unchanged, and the right to left rules still apply on the Arabic form, where the tags float right with the mirrored padding.

The widget on the Arabic right to left form after the style clean up

Test coverage is the one thing the pipeline cannot run yet, which is #3619108: Automated functional testing for Autocomplete Deluxe (2.1.x).

To review, test, then merge.

  • rajab natshah committed 82eab10c on 2.1.x authored by konot 
    ci: #3551487 Add the GitLab CI pipeline and fix the lint failures it...
rajab natshah’s picture

rajab natshah
he/him
commented
Status: Needs review » Fixed

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

rajab natshah’s picture

rajab natshah
he/him
commented
Assigned: rajab natshah » Unassigned

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.