Problem/Motivation

https://git.drupalcode.org/issue/drupal-3338664/-/jobs/6773578#L583

Manage Display (Drupal\Tests\field_ui\FunctionalJavascript\ManageDisplay)
  ✘ Formatter u i
    ┐
    ├ Behat\Mink\Exception\ExpectationException: The string "field_test_field_formatter_settings_summary_alter" was not found anywhere in the HTML response of the current page.
    │
    │ /builds/issue/drupal-3338664/vendor/behat/mink/src/WebAssert.php:888
    │ /builds/issue/drupal-3338664/vendor/behat/mink/src/WebAssert.php:363
    │ /builds/issue/drupal-3338664/core/tests/Drupal/Tests/WebAssert.php:559
    │ /builds/issue/drupal-3338664/core/modules/field_ui/tests/src/FunctionalJavascript/ManageDisplayTest.php:181
    ┴
  ✔ Widget u i
  ✔ Not applied until saved warning

Steps to reproduce

See the draft "baseline" MR's repeat test class jobs:

Proposed resolution

Use waitForText() instead of immediately trying responseContains() after clicking something.

https://git.drupalcode.org/project/drupal/-/merge_requests/14141 contains this fix.

Repeat test class jobs:

https://git.drupalcode.org/issue/drupal-3551373/-/jobs/7717822 (100x: all green)
https://git.drupalcode.org/issue/drupal-3551373/-/jobs/7718789 (500x: after also fixing testWidgetUI() - all green)

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3551373

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kentr created an issue. See original summary.

kentr’s picture

kentr commented
Priority: Normal » Critical

I believe random test failures are supposed to be critical.

dww made their first commit to this issue’s fork.

dww opened merge request !14141

dww’s picture

dww
we/he/they
commented
Status: Active » Needs review
dww’s picture

dww
we/he/they
commented
Issue tags: +Bug Smash Initiative
dww’s picture

dww
we/he/they
commented

Ran into this at https://git.drupalcode.org/issue/drupal-3560560/-/jobs/7717584 so I decided to take a look and try to smash this one.

Launched the Repeat Class test here: https://git.drupalcode.org/issue/drupal-3551373/-/jobs/7717822

dww opened merge request !14142

dww’s picture

dww
we/he/they
commented
Issue summary: View changes

Repeat class job for the "baseline" MR (the test code in the current 11.x branch) is here:

https://git.drupalcode.org/issue/drupal-3551373/-/jobs/7718440 (Repeated 500 times, failed once).

The repeat class job in the actual MR is here:

https://git.drupalcode.org/issue/drupal-3551373/-/jobs/7717822 (All green).

Adding links to relevant MRs and pipeline jobs to the summary.

dww’s picture

dww
we/he/they
commented
Title: [random test failure] ManageDisplayTest::testFormatterUI » [random test failure] ManageDisplayTest testFormatterUI() and testWidgetUI()
Issue summary: View changes

More links to repeat jobs and results.

Also, there are random fails in both testFormatterUI() and testWidgetUI(), widening scope of issue title.

dcam’s picture

dcam commented
Status: Needs review » Reviewed & tested by the community

Can't argue with results. I don't know that there's much to say about this. For the sake of due diligence I verified that these failures are coming from missing strings in responses. Waiting for those strings seems like an appropriate fix.

  • catch committed 27f1385d on 10.6.x 
    fix: #3551373 [random test failure] ManageDisplayTest testFormatterUI()...

  • catch committed 99995935 on 11.3.x 
    fix: #3551373 [random test failure] ManageDisplayTest testFormatterUI()...
catch’s picture

catch
he/him
Primary language English
commented
Version: 11.x-dev » 10.6.x-dev
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x and cherry-picked to 11.3.x and 10.6.x, thanks!

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

  • catch committed fe8bf9f8 on 11.x 
    fix: #3551373 [random test failure] ManageDisplayTest testFormatterUI()...

catch closed merge request !14141

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.