Problem/Motivation

The gitlab CI seems to be a bit wobbly on tagged releases. Cleaning up the gitlab-ci.yml and moving the cspell allowed words to their own separate file may help with this.

Issue fork sdc_component_library-3551192

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

d.fisher created an issue. See original summary.

d.fisher opened merge request !19

d.fisher’s picture

d.fisher commented
Title: Clean up CI / cspell implementation » Clean up CI / cspell / stylelint / CSS implementation
Status: Active » Needs review

Turns out the issue was around the stylelintrc.json. I've had a bit of a tidy up and implemented a (warning !!! very opinionated) set of custom css linting rules such as a-z property ordering and forced used of logical properties. This can sit here and be up for discussion but the pipelines are now passing and I'm happy with the current state of the CSS but let's see how everybody else feels about it. I will update the issue title as the scope has crept somewhat!!

d.fisher’s picture

d.fisher commented
Assigned: d.fisher » Unassigned
yustintr’s picture

yustintr commented
Status: Needs review » Reviewed & tested by the community

I think it is a fine solution

d.fisher’s picture

d.fisher commented

I'll go ahead and merge. Should be working off of 1.0.x or main for development?

d.fisher’s picture

d.fisher commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

d.fisher’s picture

d.fisher commented

Won't bother tagging a release for this as it's purely a set of development workflow changes and doesn't impact the functionality of the module in any way.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.