Motivation

Upcoming new version of custom_elements introduces the new concept of preview providers, and offers a nuxt preview provider. If the service is found, let's implement support for it by exposing an addition Select/Drowndown at the Lupus Decoupled settings screen.

Steps to reproduce

Proposed resolution

Could Lupus Decoupled conditionally register a service, based upon the configuration?

Issue fork lupus_decoupled-3550486

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

fago created an issue. See original summary.

fago opened merge request !129

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Active » Needs review

got it implemented, it's rather straight-forward - some care must be taken for installations with custom_elements module versions <3.2 which do not have the new API. I tested the code with both versions, works fine.

For gitlab-ci runs, I had a first green run without current stable custom_elements version, besides some phpstan complaining about using unexiting APIs... I'm making it work with the version now so it can run against that.

useernamee’s picture

useernamee commented

I checked MR and it looks good.

  • fago committed 07001582 on 1.x 
    [#3550486] feat: Allow selection of preview providers when custom...
fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

thank you, merged

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.