Problem/Motivation

WebformIbanFieldTest is in the src directory. This directory is not scanned for tests by Gitlab CI, so the test is never run in drupal.org infrastructure

Steps to reproduce

See https://git.drupalcode.org/project/webform_iban_field/-/pipelines/561111

Proposed resolution

Move WebformIbanFieldTest to Tests namespace

Remaining tasks

  1. Write a merge request
  2. Review
  3. Commit

User interface changes

None

API changes

None

Data model changes

None

Issue fork webform_iban_field-3550476

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !5

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request implements the following changes:

  1. Added a gitlab-ci.yml template, see https://git.drupalcode.org/project/gitlab_templates/-/blob/main/gitlab-c...
  2. The test is placed in the tests directory, so it is picked up by gitlab CI
  3. Added the webform dependency to composer.json
  4. Fixed the order of arguments for assertEquals()
  5. Added a void return type to the test method
joshahubbers’s picture

joshahubbers commented

The test runs, but fails. ;-) I will have a look at it.

idebr’s picture

idebr commented

The test is fixed now

joshahubbers’s picture

joshahubbers commented

Thanx @idebr. I will create a new release soon.

joshahubbers’s picture

joshahubbers commented
Status: Needs review » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.